Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve types #886

Merged
merged 1 commit into from
Feb 24, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,6 @@ declare namespace PptxGenJS {
| 'actionButtonReturn'
| 'actionButtonSound'
| 'arc'
| 'wedgeRoundRectCallout'
| 'bentArrow'
| 'bentUpArrow'
| 'bevel'
Expand Down Expand Up @@ -728,10 +727,6 @@ declare namespace PptxGenJS {
| 'accentCallout3'
| 'accentBorderCallout3'
| 'callout3'
| 'borderCallout3'
| 'accentCallout3'
| 'accentBorderCallout3'
| 'callout3'
| 'line'
| 'lineInv'
| 'mathDivide'
Expand Down Expand Up @@ -1287,7 +1282,7 @@ declare namespace PptxGenJS {
* @example { color:'pptx.SchemeColor.accent1' } // theme color Accent1
* @example { color:'0088CC', transparency:50 } // 50% transparent color
*/
fill?: ShapeFillProps
fill?: Color | ShapeFillProps
/**
* Flip shape horizontally?
* @default false
Expand Down Expand Up @@ -1469,7 +1464,7 @@ declare namespace PptxGenJS {
* @example 'pptx.SchemeColor.accent1' // theme color Accent1
* @example { type:'solid', color:'0088CC', alpha:50 } // ShapeFillProps object with 50% transparent
*/
fill?: ShapeFillProps
fill?: Color | ShapeFillProps
/**
* Cell margin
* @default 0
Expand Down Expand Up @@ -1601,15 +1596,15 @@ declare namespace PptxGenJS {
* - 'shrink' = Shrink text on overflow
* - 'resize' = Resize shape to fit text
*
* **Note** 'shrink' and 'resize' only take effect after editting text/resize shape.
* **Note** 'shrink' and 'resize' only take effect after editing text/resize shape.
* Both PowerPoint and Word dynamically calculate a scaling factor and apply it when edit/resize occurs.
*
* There is no way for this library to trigger that behavior, sorry.
* @since v3.3.0
* @default "none"
*/
fit?: 'none' | 'shrink' | 'resize'
fill?: ShapeFillProps
fill?: Color | ShapeFillProps
/**
* Flip shape horizontally?
* @default false
Expand Down Expand Up @@ -1780,7 +1775,7 @@ declare namespace PptxGenJS {
catAxisMinorTimeUnit?: string
catAxisMinorUnit?: string
catAxisMinVal?: number
catAxisOrientation?: 'minMax' | 'minMax'
catAxisOrientation?: 'minMax'
catAxisTitle?: string
catAxisTitleColor?: string
catAxisTitleFontFace?: string
Expand Down Expand Up @@ -1841,7 +1836,7 @@ declare namespace PptxGenJS {
valAxisMaxVal?: number
valAxisMinorTickMark?: ChartAxisTickMark
valAxisMinVal?: number
valAxisOrientation?: 'minMax' | 'minMax'
valAxisOrientation?: 'minMax'
valAxisTitle?: string
valAxisTitleColor?: string
valAxisTitleFontFace?: string
Expand Down Expand Up @@ -1906,7 +1901,7 @@ declare namespace PptxGenJS {
*/
dataLabelFormatCode?: string
dataLabelFormatScatter?: 'custom' | 'customXY' | 'XY'
dataLabelPosition?: 'b' | 'bestFit' | 'ctr' | 'l' | 'r' | 't' | 'inEnd' | 'outEnd' | 'bestFit'
dataLabelPosition?: 'b' | 'bestFit' | 'ctr' | 'l' | 'r' | 't' | 'inEnd' | 'outEnd'
}
export interface IChartPropsDataTable {
dataTableFontSize?: number
Expand Down