Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add test reproducing hunk locking problem [do not merge] #4416

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Jul 16, 2024

No description provided.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jul 16, 2024
@mtsgrd mtsgrd force-pushed the Lock-problem-reproduction branch from a6976c4 to 4ec08dd Compare July 17, 2024 00:10
@daniilS
Copy link
Contributor

daniilS commented Jul 17, 2024

@mtsgrd #4136 is another case that triggered the same error, but without changing line numbers - not sure if that would need its own regression test, or if it's also covered by this one.

@mtsgrd mtsgrd force-pushed the Lock-problem-reproduction branch from 5f2c9de to 1c3246b Compare July 17, 2024 20:34
@mtsgrd mtsgrd marked this pull request as draft July 17, 2024 20:34
@mtsgrd
Copy link
Contributor Author

mtsgrd commented Jul 17, 2024

@daniilS the two are definitely related, in that they cause(d) the same kind of panic. This one is preventable though, it's a matter of locking the change to the branch it depends on.

@mtsgrd mtsgrd changed the title Add test reproducing hunk locking problem Add test reproducing hunk locking problem [do not merge] Jul 17, 2024
@mtsgrd mtsgrd force-pushed the Lock-problem-reproduction branch from 1c3246b to 63bd442 Compare July 17, 2024 20:45
@mtsgrd mtsgrd force-pushed the Lock-problem-reproduction branch from 63bd442 to 7fcb68e Compare July 18, 2024 12:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants