Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chat Message: Code quoting follow-ups #7348

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Conversation

estib-vega
Copy link
Contributor

This pull request includes the following changes:

  1. The Diff section has been refactored into its own module for better organization.
  2. A new 'show-in-code' icon has been added to improve the user interface.
  3. An auto-scroll button has been implemented to navigate to quoted code in messages.
  4. The diff line selection behavior has been updated to remove quotes on line clicks, hide selections when quoting, and clear selections on copy actions.
  5. Users can now deselect lines by clicking outside the selected area.
  6. A fix ensures that diff selection checks for matching SHA values to prevent selecting the same line across multiple diffs.

Add a button to auto-scroll to the code quoted in a message.

This also moves the diff line encoding logic to the ui module, so that both the hunk table and its cosumers can generate the same diff line id.
- Clicking on other lines removes the quote
- Clicking on 'quote' hides the selection
- Clickin on 'copy' clears the selection
Clicking outside the selected lines
In order to avoid selecting the same line in multiple diffs, match the diff SHA
Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:04am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:04am

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant