Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add basic giphy plugin for text editor #7356

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Add basic giphy plugin for text editor #7356

merged 2 commits into from
Feb 21, 2025

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Feb 21, 2025

michael

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 9:47pm
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 9:47pm

Comment on lines 116 to 117
$inspect(fetch);
$inspect(paginator);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Something went bananas when I tried to re-order the branches.

$inspect(paginator);
</script>

<svelte:window />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not!

if (!prefixMatched) {
if (key.length === 1 && key.match(/[\w /]/)) {
inputBuffer += key;
if (inputBuffer.endsWith('/gif ')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I'm typing /gif somewhere in the middle of my commit message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, I see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing will happen unless you hit enter after first typing a valid string.

@mtsgrd
Copy link
Contributor Author

mtsgrd commented Feb 21, 2025

image

@mtsgrd mtsgrd merged commit 9a1236b into master Feb 21, 2025
23 checks passed
@mtsgrd mtsgrd deleted the giphy branch February 21, 2025 22:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants