-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Protocol Buffer text format #5716
Conversation
First of all, please don't add
|
70210d7
to
e7bb32b
Compare
Sample copied from https://github.com/google/nvidia_libs_test/blob/master/cudnn_benchmarks.textproto (Apache-2.0 License).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍 Thanks for the superb contribution!
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one request: can you please add a sample for the .pbtxt
extension.
Good idea, done. |
Could we also get .pbt added? |
Sure, though that would now need to be a new PR as I've just merged this one. |
Protocol Buffer text format is a data format, typically parsed together with a Protocol Buffers schema. Thus Protocol Buffers text format is to Protocol Buffers as XML is to XSD.
TextMate Grammar by https://github.com/thejustinwalsh/textproto-grammar (MIT licence)
Fixes #5091.
Checklist:
.pbtxt
2000k hits https://github.com/search?q=extension%3Apbtxt&type=Code.textproto
100k hits https://github.com/search?q=extension%3Atextproto&type=Code