Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Protocol Buffer text format #5716

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Jan 2, 2022

Protocol Buffer text format is a data format, typically parsed together with a Protocol Buffers schema. Thus Protocol Buffers text format is to Protocol Buffers as XML is to XSD.

TextMate Grammar by https://github.com/thejustinwalsh/textproto-grammar (MIT licence)

Fixes #5091.

Checklist:

@hickford hickford requested a review from a team as a code owner January 2, 2022 18:29
@Alhadis
Copy link
Collaborator

Alhadis commented Jan 2, 2022

First of all, please don't add language_ids manually. These need to be generated by running script/update-ids.

Secondly, how does this format differ from the currently-supported Protocol Buffer language? Is it a different format, or should .pbtxt and .textproto be added to the existing entry's extensions list?
EDIT: Never mind, I posted this before the OP was updated with links to documentation.

@hickford hickford force-pushed the textproto branch 2 times, most recently from 70210d7 to e7bb32b Compare January 2, 2022 19:35
@hickford hickford changed the title Protocol Buffers text format Protocol Buffer text format Jan 2, 2022
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 Thanks for the superb contribution!

Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one request: can you please add a sample for the .pbtxt extension.

@hickford hickford requested a review from lildude February 8, 2022 19:11
@hickford
Copy link
Contributor Author

hickford commented Feb 8, 2022

Good idea, done.

@lildude lildude merged commit 80ce80b into github-linguist:master Feb 9, 2022
@Stanzilla
Copy link
Contributor

Could we also get .pbt added?

@lildude
Copy link
Member

lildude commented Feb 9, 2022

Sure, though that would now need to be a new PR as I've just merged this one.

kalkin added a commit to kalkin/file-expert that referenced this pull request May 17, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Based Protocol Buffer Support
4 participants