Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(repository): fixes linting errors #597

Merged
merged 1 commit into from
Jan 25, 2021
Merged

test(repository): fixes linting errors #597

merged 1 commit into from
Jan 25, 2021

Conversation

hazmah0
Copy link
Contributor

@hazmah0 hazmah0 commented Nov 4, 2019

Fixes that lint task is failing in CI since merging #588

brandonbothell
brandonbothell approved these changes Jan 5, 2020
View reviewed changes
Copy link

@brandonbothell brandonbothell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A failing test doesn't look too good and hinders PR compatibility checks.

@DanielRuf
Copy link

@jasonhaxstuff not sure what you mean, mistakes happen.

@brandonbothell
Copy link

brandonbothell commented Jan 5, 2020 •
edited
Loading

@DanielRuf I was stating a reason of approval. Pretend like I prefaced my comment with "I'm approving this because...".

@j-rewerts j-rewerts merged commit 8a4691f into github-tools:master Jan 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@brandonbothell brandonbothell brandonbothell approved these changes

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hazmah0 @DanielRuf @brandonbothell @j-rewerts