Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: standardize github action types #92

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Jun 7, 2024

Pull Request

Proposed Changes

  • use one line lists for types and branches
  • fix formatting (random 2 space column on some of the workflows)
  • add edited and reopened to some of the workflows

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

- [x] use one line lists for types and branches
- [x] fix formatting (random 2 space column on some of the workflows)
- [x] add `edited` and `reopened` to some of the workflows

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Jun 7, 2024
@jmeridth jmeridth requested review from sutterj and zkoppert as code owners June 7, 2024 21:36
on:
# pull_request_target event is required for autolabeler to support all PRs including forks
pull_request_target:
types: [ opened, reopened, edited, synchronize ]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meat of change, adding edited here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. like a light meat. A single slice of pepperoni. 👨🏻‍🍳

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkoppert zkoppert merged commit ab356ad into main Jun 7, 2024
23 checks passed
@zkoppert zkoppert deleted the jm_workflow_types branch June 7, 2024 22:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants