Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove source from list of HTML block elements #265

Merged
merged 1 commit into from
May 31, 2022
Merged

Remove source from list of HTML block elements #265

merged 1 commit into from
May 31, 2022

Conversation

lumaxis
Copy link

@lumaxis lumaxis commented May 25, 2022

Implements the spec change from commonmark/commonmark-spec#710

phillmv
phillmv approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@phillmv phillmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the correctness of scanners.re but I can confirm that the existing change is minor and now matches up spec. Good job getting it merged upstream first :D.

@lumaxis lumaxis merged commit dd77eb0 into master May 31, 2022
@lumaxis lumaxis deleted the remove-source-html-blocks branch May 31, 2022 10:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthiaswenz matthiaswenz matthiaswenz approved these changes

@phillmv phillmv phillmv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumaxis @phillmv @matthiaswenz