Skip to content

Clean up running queries some more #2065

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

henrymercer
Copy link
Contributor

Now that we have deprecated parsing the configuration in the Action, we can simplify running queries to reflect that:

  • We will run all the queries for a language in one group, so we can always pass --expect-discarded-cache.
  • We no longer specify query suites when running queries, so we can delete the logic for doing this. Instead the query suite is stored within the database.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 5, 2024 19:13
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me!

@henrymercer henrymercer merged commit fd55bb0 into main Jan 8, 2024
@henrymercer henrymercer deleted the henrymercer/further-run-queries-cleanup branch January 8, 2024 11:11
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants