Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PR checks: small fixups to prepare-action #2548

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

angelapwen
Copy link
Contributor

While working on a version of this for testing on runner images, I noticed some improvements to be made:

  • the action now expects stable CLI version inputs as stable-vX.Y.Z rather than with dates. Our current PR checks already use this format but the documentation for the input needed to be updated.
  • the nightly version format also should expect nightly-YYYYMMDD rather than with dashes
  • the nightly bundle URL formatting has been corrected to remove the manual suffix — eg. the current nightly URLs look like: https://github.com/dsp-testing/codeql-cli-nightlies/releases/download/codeql-bundle-20240823/codeql-bundle-linux64.tar.gz. We haven't caught this because none of our PR checks use the dated nightly bundles.
  • when the version is linked or default we return the appropriate tools input early.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen force-pushed the angelapwen/fix-prepare-test branch from 9092cbf to 2f0f924 Compare October 15, 2024 23:17
@angelapwen angelapwen marked this pull request as ready for review October 15, 2024 23:28
@angelapwen angelapwen requested a review from a team as a code owner October 15, 2024 23:28
@angelapwen angelapwen merged commit ad94f2f into main Oct 16, 2024
548 checks passed
@angelapwen angelapwen deleted the angelapwen/fix-prepare-test branch October 16, 2024 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants