Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merge main into releases/v3 #2715

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Merge main into releases/v3 #2715

merged 4 commits into from
Jan 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Merging b44b19f into releases/v3.

Conductor for this PR is @smowton.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v3 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Mark the PR as ready for review to trigger the full set of PR checks.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.
  • Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.

@smowton smowton marked this pull request as ready for review January 23, 2025 16:29
@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 16:29
@smowton smowton requested a review from a team as a code owner January 23, 2025 16:29
Copilot
Copilot AI reviewed Jan 23, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

CHANGELOG.md
Comment on lines +7 to +8
No user facing changes.

Copy link
Preview

Copilot AI Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Rewrite 'user facing' as 'user-facing' for clarity and correctness.

Suggested change
No user facing changes.
No user-facing changes.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@smowton smowton enabled auto-merge January 23, 2025 16:32
@smowton smowton merged commit ee117c9 into releases/v3 Jan 23, 2025
251 checks passed
@smowton smowton deleted the update-v3.28.4-b44b19fe8 branch January 23, 2025 16:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@smowton smowton smowton approved these changes

Assignees

@smowton smowton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smowton @angelapwen