Make use of the GITHUB_ACTION_REPOSITORY environment variable if it is set.
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
force-pushed
the
use-github-action-repository-variable
branch
from
6698486 to
bf30ea6
Compare
robertbrignull
approved these changes
Nov 10, 2020
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the change in actions/runner#585 is merged it should be possible to make use of the new
GITHUB_ACTION_REPOSITORYenvironment variable, rather than relying on the more brittle guess at the name of the Action being used.Unfortunately we can't fully remove the logic where we guess the Action repository name by the path at which it is checked out because users of GHES 2.22 might still need this, but it does mean we can put a final sunset date on the removal of this code once 2.22 reaches end-of-support.
I've also added some info-level logging in the hopefully rare case that
GITHUB_ACTION_REPOSITORYis not set in order to help debug any issues caused by the guessing logic.Merge / deployment checklist