Rust: generate the extractor #17543
Merged
Rust: generate the extractor #17543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
aibaars/rust-gen-extractor
branch
from
d34d865
to
592182c
Compare
aibaars
force-pushed
the
aibaars/rust-gen-extractor
branch
from
592182c
to
7b4137f
Compare
hvitved
reviewed
Sep 24, 2024
| @@ -0,0 +1,2185 @@ | |||
| use super::base::{TextValue, Translator}; | |||
There was a problem hiding this comment.
I think it's nice when generated code starts with a comment like generated code, do not edit.
There was a problem hiding this comment.
Yes, good idea; I also added some linguist-generated entries to .gitattributes
rust/extractor/src/main.rs
Outdated
|
|
||
| pub fn extract( |
There was a problem hiding this comment.
Does this need to be public?
There was a problem hiding this comment.
No, it can be private.
hvitved
approved these changes
Sep 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request splits the
translate.rsfile of the extractor in two parts, the non-generated part (base.rs) and the generated codegenerated.rs.The extractor can be regenerated by running
cargo runinrust/generate-schema.