Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use "nearest" behavior for scrollIntoView #79

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Use "nearest" behavior for scrollIntoView #79

merged 1 commit into from
Dec 23, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 23, 2023 •
edited
Loading

@wxiaoguang wxiaoguang requested a review from a team as a code owner December 23, 2023 15:35
This was referenced Dec 23, 2023
Closed
Merged
keithamus
keithamus approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithamus keithamus merged commit ea5e8d6 into github:main Dec 23, 2023
@keithamus
Copy link
Member

https://github.com/github/combobox-nav/releases/tag/v2.3.1

wxiaoguang added a commit to go-gitea/gitea that referenced this pull request Dec 24, 2023
@wxiaoguang
Fix the scroll behavior for emoji/mention list (#28597)
8a71f72 
Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)
@GiteaBot GiteaBot mentioned this pull request Dec 24, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 24, 2023
@wxiaoguang @GiteaBot
Fix the scroll behavior for emoji/mention list (go-gitea#28597)
ffa524d 
Fix go-gitea#28595 by github/combobox-nav#79 (combobox-nav v2.3.1)
@wxiaoguang wxiaoguang mentioned this pull request Dec 24, 2023
Open
wxiaoguang added a commit to go-gitea/gitea that referenced this pull request Dec 25, 2023
@GiteaBot @wxiaoguang
Fix the scroll behavior for emoji/mention list (#28597) (#28601)
8a46a64 
Backport #28597 by wxiaoguang

Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 16, 2024
@GiteaBot @earl-warren
Fix the scroll behavior for emoji/mention list (#28597) (#28601)
fef19bc 
Backport #28597 by wxiaoguang

Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 8a46a64)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Fix the scroll behavior for emoji/mention list (go-gitea#28597)
87bc26a 
Fix go-gitea#28595 by github/combobox-nav#79 (combobox-nav v2.3.1)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Fix the scroll behavior for emoji/mention list (go-gitea#28597)
8a0dc00 
Fix go-gitea#28595 by github/combobox-nav#79 (combobox-nav v2.3.1)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The UX is broken with v2.3.0 of @github/combobox-nav dependency
2 participants
@wxiaoguang @keithamus