Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Achewood improvements #1114

Merged
merged 5 commits into from
Sep 6, 2013
Merged

Achewood improvements #1114

merged 5 commits into from
Sep 6, 2013

Conversation

ymendel
Copy link
Contributor

@ymendel ymendel commented Sep 4, 2013

Let's clean up some of this to make our Achewood experience better.

cc @gjtorikian, @balevine, @thedaniel, @kelseyschimm, @technicalpickles

@gjtorikian
Copy link

for great justice ❤️

@kelseyschimm
Copy link

👍 👍

@gjtorikian
Copy link

oh can you make the date optionally depend on / ? that way we can just copy paste from the URL.

@thedaniel
Copy link
Contributor

fairly sure ymendel owns airwolf. this is not coded language. he has airwolf and is flying it while writing this code.

@ymendel
Copy link
Contributor Author

ymendel commented Sep 4, 2013

@gjtorikian : That was the first thing I did.

@kelseyschimm
Copy link

I only know HTML. It's cool, there's still something we can all talk about. Like how I let my family down.

@technicalpickles
Copy link
Contributor

In the spirit of #1113 maybe we can move this to it's own package?

@ymendel
Copy link
Contributor Author

ymendel commented Sep 4, 2013

Okay, I think this works well now.

We can move to a separate package, but I'm not too sure about what's necessary.

@tombell
Copy link
Contributor

tombell commented Sep 4, 2013

Give https://github.com/hubot-scripts/hubot-example a gander, it's an example package I wrote.

@tombell
Copy link
Contributor

tombell commented Sep 5, 2013

I can add you as a member to the hubot-scripts org @ymendel so you can push the package to their if that is more convenient.

@ymendel
Copy link
Contributor Author

ymendel commented Sep 5, 2013

Yeah, this makes more sense under hubot-scripts. I'll try to work something out and push it up 🔜.

technicalpickles added a commit that referenced this pull request Sep 6, 2013
@technicalpickles technicalpickles merged commit 171e318 into master Sep 6, 2013
@technicalpickles technicalpickles deleted the achewood_betterness branch September 6, 2013 14:56
@technicalpickles
Copy link
Contributor

I was going to cut a release, so figured I'd include this.

@ymendel
Copy link
Contributor Author

ymendel commented Sep 6, 2013

That's awesome, but it lowers my motivation to make a separate package. 😉

@technicalpickles
Copy link
Contributor

@ymendel don't worry about it. I'll look at extracting the scripts we use out of this repo to their own packages at some point.

@@ -36,16 +37,22 @@ module.exports = (robot) ->
msg.send "http://achewood.com" + comic.src + "#.png"
msg.send comic.title

robot.respond /achewood\s?((0[1-9]|1[0-2]).(0[1-9]|[1-2][0-9]|3[0-1]).(20\d{2})$|current)?/i, (msg) ->
if msg.match[1] == undefined
robot.respond /achewood\s?((?:0[1-9]|1[0-2]).?(?:0[1-9]|[1-2][0-9]|3[0-1]).?(?:20\d{2})$|.*)?/i, (msg) ->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, I guess I broke this entirely

COFFEESCRIPT!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymendel ymendel mentioned this pull request Sep 6, 2013
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants