Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Use proper HUBOT_ namespacing for Resumator ENV vars #1209

Closed
wants to merge 2 commits into from
Closed

Use proper HUBOT_ namespacing for Resumator ENV vars #1209

wants to merge 2 commits into from

Conversation

ocxo
Copy link
Contributor

@ocxo ocxo commented Oct 31, 2013

Better follows the convention of HUBOT_ prefixing on ENV vars

@technicalpickles
Copy link
Contributor

I'd suggest checking both initially, for backwards compatability. Otherwise, it'll just stop working for people.

Also, we are generally moving packages out of this repository in favor of separate npm package/repositories, so if you have any interest in maintaining this script, it'd be a great way to help out! Check out #1113 for more info.

@technicalpickles
Copy link
Contributor

I've been merging stuff despite #1113, but not going to do this one since it'll break backwards compatibility.

@ChrisMissal
Copy link
Contributor

@technicalpickles Do you think it's safe to just create a new version and publish on npm? The users of the old script will not have obtained it through npm and it could then be versioned like normal.

Sorry, I haven't really kept up with all the hubot-scripts changes and moves over the past couple years.

@technicalpickles
Copy link
Contributor

@ChrisMissal I just released 2.16.2, thanks for the reminder ✨

@ChrisMissal
Copy link
Contributor

Sure thing 😄

I just ran across this issue and was curious if there was anything I could do to help (fix/improve/etc) with the resumator.coffee script since I created it.

@ocxo ocxo deleted the resumator-env-namespacing branch August 13, 2015 02:48
@technicalpickles
Copy link
Contributor

@ChrisMissal well since you asked 😁 ... we are trying to get folks to extract scripts out of this repository and moved into their own. See #1641 and #1113 for background. If you do want to extract resumator, just let us know over on #1641 when it's been released ✨

@ChrisMissal
Copy link
Contributor

@technicalpickles Done 👍

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants