Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: improve auth test coverage #426

Merged
merged 2 commits into from
Nov 5, 2024
Merged

test: improve auth test coverage #426

merged 2 commits into from
Nov 5, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Nov 5, 2024

improve auth test coverage by adding invalid and failed app install tests

Pull Request

Proposed Changes

This pull request adds new test cases to the test_auth.py file to improve the coverage and robustness of the authentication functions. The most important changes include importing the requests library, adding a test for handling request failures, and adding a test for handling invalid credentials.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

by adding missing and failed app install tests

Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert marked this pull request as ready for review November 5, 2024 05:18
@zkoppert zkoppert requested a review from Copilot November 5, 2024 05:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@jmeridth jmeridth merged commit 2ab9714 into main Nov 5, 2024
35 checks passed
@jmeridth jmeridth deleted the auth-test-coverage branch November 5, 2024 05:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants