-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add test cases for superfluous days #263
base: main
Are you sure you want to change the base?
Conversation
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a De#frastructure first responder will review it soon.
|
I'd love for @keithamus to approve this as he is working on it. Fine from primer FR side |
Thanks, I'm looking into fixing this but I have higher priorities for now. A fix will come though! |
Sorry for the delay on my end, adding this to the first responder board to pick up 👀 @keithamus just wanted to check-in, what are the next steps for this? |
I looked into this today and have become thoroughly confused. Are you specifying any If I try copy/pasting your test cases into example/index.html, it always gives me something like "1 year, 6 days, 4 minutes, 24 seconds." I don't understand why the tests fail the way they do when no |
@camertron according to the README the precision defaults to I just put this into an HTML (using v4.4.4 via npm): <relative-time format="duration" datetime="1944-12-13"></relative-time> It showed "81 years, 2 months, 22 hours, 21 minutes, 45 seconds" for me. Even if I set the precision as high as |
This PR adds cases for whole years and whole months to not have extra days, e.g. May (
2023-05-11T00:00:00.00
) to July (2023-07-11T00:00:00.00
) being2 months
instead of current2 months, 1 day
.Related issue: #262