Commit test fixes that were missing from the published version commit.

github · Jan 17, 2023 · 461e8d6 · 461e8d6
1 parent beac416
commit 461e8d6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/webauthn-json/extended.spec.ts b/src/webauthn-json/extended.spec.ts
@@ -13,6 +13,10 @@ import {
 import { convert } from "./convert";
 import "./arraybuffer.jest";
 
+const unimplemented: any = () => {
+  throw new Error("unimplemented");
+};
+
 describe("extended schema", () => {
   test("converts CredentialCreationOptionsExtendedJSON", () => {
     const cco: CredentialCreationOptionsExtendedJSON = {
@@ -63,6 +67,9 @@ describe("extended schema", () => {
       response: {
         clientDataJSON: new Uint8Array([9, 10, 11, 12]),
         attestationObject: new Uint8Array([13, 14, 15, 16]),
+        getAuthenticatorData: unimplemented,
+        getPublicKey: unimplemented,
+        getPublicKeyAlgorithm: unimplemented,
         getTransports: () => ["usb"],
       } as AuthenticatorAttestationResponse,
       getClientExtensionResults: () =>

diff --git a/src/webauthn-json/extended/api.ts b/src/webauthn-json/extended/api.ts
@@ -4,7 +4,10 @@ import {
   Base64urlString,
 } from "../base64url";
 import { convert } from "../convert";
-import { AuthenticatorAttestationResponseJSON } from "../basic/json";
+import {
+  AuthenticatorAttestationResponseJSON,
+  PublicKeyCredentialWithClientExtensionResults,
+} from "../basic/json";
 import {
   CredentialCreationOptionsExtendedJSON,
   CredentialRequestOptionsExtendedJSON,
@@ -33,7 +36,7 @@ export function createExtendedRequestFromJSON(
 }
 
 export function createExtendedResponseToJSON(
-  credential: PublicKeyCredential,
+  credential: PublicKeyCredentialWithClientExtensionResults,
 ): PublicKeyCredentialWithAttestationExtendedResultsJSON {
   return convert(
     bufferToBase64url,
@@ -113,7 +116,7 @@ export function getExtendedRequestFromJSON(
 }
 
 export function getExtendedResponseToJSON(
-  credential: PublicKeyCredential,
+  credential: PublicKeyCredentialWithClientExtensionResults,
 ): PublicKeyCredentialWithAssertionExtendedResultsJSON {
   return convert(
     bufferToBase64url,