[dashboard] try using skeletons for loading repo suggestions #20766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Apr 24, 2025
There was a problem hiding this comment.
The diff shows many changes in this file, you'll be happier with hiding whitespace changes.
|
@filiptronicek Can you add a git integration or make me admin? |
|
@gero just did both |
|
Please keep in mind it can take up to 10m to get from the empty state to content, because of how our caching for the queries is set up (we cache the suggested repository query quite heavily to make it snappy most of the time) |
geropl
reviewed
Apr 24, 2025
components/dashboard/src/data/git-providers/suggested-repositories-query.ts
Outdated
Show resolved
Hide resolved
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've received feedback that the suggested repos component can trigger layout shifts. This PR attempts to fix those.
Related Issue(s)
Fixes CLC-1307
How to test
TBD
Preview
https://ft-improve13010e87f3.preview.gitpod-dev.com/workspaces