Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

GitPython not returning error #271

Closed
tardis4500 opened this issue Mar 20, 2015 · 2 comments
Closed

GitPython not returning error #271

tardis4500 opened this issue Mar 20, 2015 · 2 comments
Assignees
@Byron
Labels
acknowledged
Milestone
v0.3.7 - Fixes

Comments

@tardis4500
Copy link

When I run the command from the command line
git push -u --all origin
it fails with
remote: import failed: User not permitted to commit
and exit code of 1.

But doing the same thing programmatically in GitPython does not show any error at all even though I can see the push was unsuccessful because the changes were not pushed.
@Byron Byron added this to the v0.3.7 - Fixes milestone Mar 20, 2015
@Byron
Copy link
Member

Byron commented Mar 20, 2015

I believe to have found the source of this issue: For some reason, it will only treat exit code 128 as error, as can be seen here.

This should probably just re-raise - at least I can't see why there is this kind of special treatment.

@Byron Byron self-assigned this Apr 8, 2015
Byron added a commit that referenced this issue Apr 8, 2015
@Byron
fix(docs): be clear about exit code handling
723f100 
When pushing/pulling, we ignore errors unless it's exit code 128.
The reason for this is now made explicit to make clear that issues
are handled by PushInfo flags accordingly.

Related #271
@Byron Byron closed this as completed in e9f8f15 Apr 8, 2015
@Byron
Copy link
Member

Byron commented Apr 8, 2015

You can watch the development stream on youtube.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Byron Byron

Labels
acknowledged
Milestone
v0.3.7 - Fixes
Development

No branches or pull requests
2 participants
@Byron @tardis4500