Fix "known" Windows errored test cases #525

ankostis · 2016-10-03T02:33:47Z

Currently, Windows TestCases on Appveyor established on #519 are "artifically" ok.
Because in the code, the Test Cases known to fail on have been marked with the HIDE_WINDOWS_KNOWN_ERRORS variable so that we get an ALL GREEN response; that way we can detect when new commits break additional TCs on Windows.

Currently there are 10 failing TCs (search them with the above var-name), and you can view the errors in this Appveyor job:

https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.196

The errors are mostly related to 2 issues:

Unicode: for those with reading time, I would suggest these 2 contradictory sources:
- problem: Everything you did not want to know about Unicode in Python 3
- solution: PEP 383 -- Non-decodable Bytes in System Character Interfaces - so using text-mode
Leaked resources: these are (possibly memmory-mapped) files that are not deallocated (and hence, not deleted afterwards). Unfortunately, dealing with them might mean that you have to jump projects, as some are inherited from the library projects smmp and (mostly) gitdb.

In order to reproduce the failed TCs on your PC, change locally git/test/lib/helper.py:#L38 from this:

    HIDE_WINDOWS_KNOWN_ERRORS = os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', True)

into this:

    HIDE_WINDOWS_KNOWN_ERRORS = os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', False)

This issue is about not forgetting these TCs - asking for help to fix them.

The text was updated successfully, but these errors were encountered:

+ Parse all config-urls \-->/. + Used relative daemon-paths. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() freezes now! (hidden win_err)

+ Parse all config-urls \-->/. + Used relative daemon-paths. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() freezes now! (hidden win_err) + repo_test: minor finally delete test-repos created inside this repo.

+ Parse all config-urls \-->/. + Used relative daemon-paths. + Use git-daemon PORT above 10k; on Windows all below need Admin rights. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() freezes now! (hidden win_err) + repo_test: minor finally delete test-repos created inside this repo.

Byron · 2016-10-09T09:52:09Z

@ankostis Even though I won't be of much help here, I have just provided you with full write permissions on all the gitpython repositories that matter. Previously, I believe you might have been missing write access to smmap, for no other reason than me having forgotten to set it up right away :).

+ Parse all config-urls \-->/. + Used relative daemon-paths. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() freezes now! (hidden win_err) + repo_test: minor finally delete test-repos created inside this repo.

+ Parse all config-urls \-->/. + Used relative daemon-paths. + Use git-daemon PORT above 10k; on Windows all below need Admin rights. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() now freezes! (so still hidden win_err) + repo_test: minor finally delete test-repos created inside this repo.

+ Parse most remote & config-urls \-->/. + Used relative daemon-paths. + Use git-daemon PORT above 10k; on Windows all below need Admin rights. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() now freezes! (so still hidden win_err) + repo_test: minor finally delete test-repos created inside this repo. + util: delete unused `absolute_project_path()`.

+ FIXED also `TestSubmodule.test_root_module()`!

+ Parse most remote & config-urls \-->/. + Used relative daemon-paths. + Use git-daemon PORT above 10k; on Windows all below need Admin rights. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() now freezes! (so still hidden win_err) + repo_test: minor finally delete test-repos created inside this repo. + util: delete unused `absolute_project_path()`.

+ cmd: use DEVNULL for non PIPEs; no open-file. + TCs: some unitestize-assertions on base & remote TCs.

…d stderr

+ Parse most remote & config-urls \-->/. + Used relative daemon-paths. + Use git-daemon PORT above 10k; on Windows all below need Admin rights. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() now freezes! (so still hidden win_err) + repo_test: minor finally delete test-repos created inside this repo. + util: delete unused `absolute_project_path()`.

[travisci skip]

+ Rework git-daemon launching with `with` resource-management. + cmd: add `is_cygwin` optional override kwd on `Git.polish_url()`.

- Cygwin TCs failing (start, no Cygwin specific code): - PY2: err: 44, fail: 0 - PY3: err: 13, fail: 0

+ Make `Git.polish_url()` convert paths into Cygwin-friendly paths. + Add utility and soe TCs for funcs for detecting cygwin and converting abs-paths to `/cygdrive/c/...`. - Cygwin TCs failing: - PY2: err: 14, fail: 3 - PY3: err: 13, fail: 3

+ Rework git-daemon launching with `with` resource-management. + cmd: add `is_cygwin` optional override kwd on `Git.polish_url()`. - Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

- Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

…init - Cygwin TCs failing: - PY2: err: 13, fail: 2 - PY3: err: 12, fail: 2

+ Bug discovered after enabling TC in prev commit and rework of fetch. + remote_tc: unitestize assertions. + util: DEL unused `_mktemp()`.

…ions + Ignore `with_extended_output` arg when reaising the exception, keep its behavior when `status==0`.

+ git-daemon: + Use git-daemon PORT above 10k; on Windows all below need Admin rights. + Used relative daemon-paths with `--base-pth`. + Simplify git-daemon start/stop/ex-hanlding. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + "Polish" most remote & config urls, converting \-->/. + test_base.test_with_rw_remote_and_rw_repo() PASS. + Remote: + test_remote: apply polish-urls on `_do_test_fetch()` checking function. + test_remote.test_base() now freezes on Windows! (so still hidden win_err). pump fetch-infos instead of GIL-reading stderr. + Push-cmd also keep (and optionally raise) any error messages. + `cmd.handle_process_output()` accepts null-finalizer, to pump completely stderr before raising any errors. + test: Enable `TestGit.test_environment()` on Windows (to checks stderr consumption). + util: delete unused `absolute_project_path()`. + Control separately *freezing* TCs on Windows with `git.util.HIDE_WINDOWS_FREEZE_ERRORS` flag.

Drop Windows only codepath bypassing memory-mapping due to some leaks in the past. Now Appveyor proves everything run ok. Additionally, this codepath had unicode problems on PY3. So deleting it, fixes 2 TCs in gitpython: + TestRepo.test_file_handle_leaks() + TestObjDbPerformance.test_random_access() See gitpython-developers/GitPython#525

ankostis added critical help wanted tag.Windows labels Oct 3, 2016

ankostis added a commit that referenced this issue Oct 3, 2016

doc: Explain Windows compatibility status, mention #525 asking for help

86aa873

This was referenced Oct 10, 2016

gitpython-2.0.9.dev0 has run-time dependency on nose #526

Closed

Issues with AutoInterrupt in conjunction with sys.exit on python 3.5 #463

Closed

ankostis added the tag.leaks label Oct 11, 2016

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

daemon, gitpython-developers#525: simplify exception handling

0f131a0

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

daemon, gitpython-developers#525: simplify exception handling

6d441c9

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

config, gitpython-developers#525: polish more config-urls

3358136

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

config, gitpython-developers#525: polish more config-urls

534ad09

+ FIXED also `TestSubmodule.test_root_module()`!

ankostis added a commit that referenced this issue Oct 12, 2016

config, #525: polish more config-urls

6486b8c

+ FIXED also `TestSubmodule.test_root_module()`!

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

config, gitpython-developers#525: polish more config-urls

21a5087

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

daemon, gitpython-developers#525: simplify exception handling

6e56b3c

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

config, gitpython-developers#525: polish more config-urls

49a8cdd

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

test, gitpython-developers#525: allow disabling freeze errors separately

c6b0a0a

+ cmd: use DEVNULL for non PIPEs; no open-file. + TCs: some unitestize-assertions on base & remote TCs.

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

test, gitpython-developers#525: allow disabling freeze errors separately

e6853d5

+ cmd: use DEVNULL for non PIPEs; no open-file. + TCs: some unitestize-assertions on base & remote TCs.

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

remote, gitpython-developers#525: pump fetch-infos instead of GIL-rea…

4d67069

…d stderr

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 12, 2016

daemon, gitpython-developers#525: simplify exception handling

0d8269a

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 13, 2016

appvayor, gitpython-developers#525: enable CYGWIN TCs without failing.

fcf8a42

[travisci skip]

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 13, 2016

appvayor, gitpython-developers#525: enable CYGWIN TCs without failing.

5ccefe6

[travisci skip]

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 13, 2016

appveyor, gitpython-developers#525: enable CYGWIN TCs without failing

003b02f

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 13, 2016

appveyor, gitpython-developers#525: enable CYGWIN TCs without failing

11c0ca9

[travisci skip]

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 13, 2016

appveyor, gitpython-developers#525: enable CYGWIN TCs without failing

6f5c9bd

[travisci skip]

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 13, 2016

appveyor, gitpython-developers#525: enable CYGWIN TCs without failing

01751aa

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

cygwin, gitpython-developers#525: FIX daemon launching

b2c59a2

+ Rework git-daemon launching with `with` resource-management. + cmd: add `is_cygwin` optional override kwd on `Git.polish_url()`.

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

cygwin, gitpython-developers#525: Polish also --git-separate-dir

ec75656

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

appveyor, gitpython-developers#525: enable CYGWIN TCs without failing

d57b53b

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

appveyor, gitpython-developers#525: enable CYGWIN TCs without failing

e2a8978

- Cygwin TCs failing (start, no Cygwin specific code): - PY2: err: 44, fail: 0 - PY3: err: 13, fail: 0

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

cygwin, gitpython-developers#525: Polish also --git-separate-dir

b2749b1

- Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

cygwin, gitpython-developers#525: Allow '/cygdrive/c/' paths on repo …

5179f87

…init - Cygwin TCs failing: - PY2: err: 13, fail: 2 - PY3: err: 12, fail: 2

ankostis added a commit to ankostis/GitPython that referenced this issue Oct 14, 2016

cmd, gitpython-developers#525: Always include stdout+stderr in except…

c8e914e

…ions + Ignore `with_extended_output` arg when reaising the exception, keep its behavior when `status==0`.

ankostis mentioned this issue Oct 14, 2016

Support Cygwin's Git on Windows #533

Merged

ankostis mentioned this issue Oct 22, 2016

fix(MapWindow): unicode foes in read_into_memory() used by gitpython TCs gitpython-developers/smmap#30

Merged

ankostis mentioned this issue Oct 22, 2016

Stop emulating mmap on Windows #542

Merged

ankostis mentioned this issue Mar 27, 2017

Windows fixes for leaking file handles #37 gitpython-developers/gitdb#38

Merged

ankostis mentioned this issue Nov 28, 2017

BF (codename "happy travis"): trying to address lints etc to make Travis green again #702

Merged

tarkatronic mentioned this issue Aug 25, 2020

Consider switching away from GitPython godaddy/tartufo#66

Closed

ericzolf mentioned this issue Dec 28, 2020

add --gitignore option to not sync gitignored files rdiff-backup/rdiff-backup#502

Closed

EliahKagan mentioned this issue Sep 26, 2023

Make clear every test's status in every CI run #1679

Merged

EliahKagan mentioned this issue Jan 26, 2024

Don't suppress messages when logging is not configured #1813

Merged

joshuacwnewton mentioned this issue Dec 13, 2024

CLI: Log/print commit hash, and --version option axondeepseg/axondeepseg#847

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix "known" Windows errored test cases #525

Fix "known" Windows errored test cases #525

ankostis commented Oct 3, 2016 •

edited

Loading

Byron commented Oct 9, 2016

Uh oh!

Uh oh!

Fix "known" Windows errored test cases #525

Fix "known" Windows errored test cases #525

Comments

ankostis commented Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Byron commented Oct 9, 2016

Uh oh!

ankostis commented Oct 3, 2016 •

edited

Loading