Skip to content

Fix inheritance issue at commit.iter_items #1119

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

yvolchkov
Copy link

The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.

Signed-off-by: Yuri Volchkov yuri@volch.org

The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.

Signed-off-by: Yuri Volchkov <yuri@volch.org>
@yvolchkov
Copy link
Author

I am not sure the test failure:

   stderr: 'fatal: unable to connect to localhost:
localhost[0: ::1]: errno=Connection refused
localhost[1: 127.0.0.1]: errno=Connection refused

is related to my changes anyhow...

Is that a known issue. Or could someone help me figure out what is wrong?

@Byron Byron added this to the v3.1.13 - Bugfixes milestone Feb 5, 2021
@Byron
Copy link
Member

Byron commented Feb 5, 2021

Thanks a lot for the fix!
The tests failed spuriously, which is a rare event on CI.

@Byron Byron merged commit 9de6450 into gitpython-developers:master Feb 5, 2021
@yvolchkov
Copy link
Author

thanks for the quick merge! Are you planning a release soon by any chance? :)

@Byron
Copy link
Member

Byron commented Feb 9, 2021

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants