-
-
Notifications
You must be signed in to change notification settings - Fork 942
DNM before 2021-09-05: Remove support for Python 3.5 #1201
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks so much! I will merge this one in half a year from now 😁. |
Why waiting so long for removal of py35? One extra year after py35 already hit EOL seems too much for me. PS. I say this only because I know the py36 opens the door of static typing, which highly appreciated on any library. |
Thanks for sharing the value provided by dropping python 3.5 earlier. Some types have already been added and for that python 3.4 support was dropped I believe, I assume python 3.6 provides even better ways of inline typing? In any case, I would be happy to accept a PR which drops python 3.5 support while adding more types in a way that require python 3.6 and thus makes good use of the value added by dropping support earlier. |
Just to add (prompted by #1270): |
@Yobmod Does that mean this PR needs additional work? Otherwise I would be merging it early, yank the current version on pypi once more and drop python 3.5 support with the next. |
I dont think any reason to delay this PR or a release. Once this is merged I'll submit a separate PR with the typing improvements it makes possible. They won't change much but will cleanup some cast() and type ignores, so can be put in a subsequent release if I don't get to it tonight. |
Delaying removal of py35 support would do more damage than good to project mainly due to extra maintenance involved. |
@Yobmod and @bertwesarg Interestingly now that this branch is merged it fails on CI with failures I can't really fix without spending more time than I have. Maybe it's easy for you to fix due to your experience and I am looking forward to a PR. In the mean time, I will undo the merge to get main fixed right away. 820d3cc would be the one to revert and take a look at. |
I reverted the revert…effectively re-adding the removal of python 3.5 as main fails generally now, independently of this commit. |
No description provided.