Fuzzing: Fix Broken Fuzz Test for Git Submodule Handling #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensured submodule names, paths, and commit messages are sanitized to avoid invalid states that are expected to cause exceptions and should not halt the fuzzer. In particular, the changes here: - Sanitized inputs for submodule names, paths, and commit messages. - Added validation for submodule SHA and path integrity.
Byron
approved these changes
Jan 11, 2025
DaveLak
deleted the
fuzzing/fuzz-targets/git-broken-fuzz-submodule-test
branch
|
This worked. Issue now resolved on the OSS-Fuzz tracker: https://issues.oss-fuzz.com/379326001 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
As you may or may not have seen, the
fuzz_submodule.pyharness has been failing for some time now and I believe it is responisble for the "fuzzing build: failing" status on OSS-Fuzz.I looked into it and it appears to be an issue with the test implementation, not GitPython.
The changes here should fix the issue causing the failure!
Please see the commit message for additional details.