Skip to content

Add support to pass clone options that can be repeated multiple times #836

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

ninloot
Copy link
Contributor

@ninloot ninloot commented Feb 4, 2019

This PR addresses issue #824, allowing options to be passed directly without additional processing by the underlying framework.

@ninloot
Copy link
Contributor Author

ninloot commented Feb 4, 2019

It appears that the tests that are failing were failing prior to my change so I don't think my change is a regression.

@codecov-io
Copy link

Codecov Report

Merging #836 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   94.79%   94.67%   -0.12%     
==========================================
  Files          59       59              
  Lines        9603     9398     -205     
==========================================
- Hits         9103     8898     -205     
  Misses        500      500
Impacted Files Coverage Δ
git/test/test_repo.py 97.92% <100%> (-0.04%) ⬇️
git/repo/base.py 95.28% <100%> (-0.09%) ⬇️
git/objects/tree.py 59.64% <0%> (-0.93%) ⬇️
git/index/util.py 90.69% <0%> (-0.61%) ⬇️
git/index/typ.py 96.82% <0%> (-0.58%) ⬇️
git/refs/log.py 93.84% <0%> (-0.53%) ⬇️
git/objects/base.py 95.83% <0%> (-0.33%) ⬇️
git/refs/tag.py 96.66% <0%> (-0.31%) ⬇️
git/test/lib/helper.py 91.86% <0%> (-0.28%) ⬇️
git/refs/reference.py 95.74% <0%> (-0.26%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f66e25...8954986. Read the comment docs.

@Byron
Copy link
Member

Byron commented Jul 6, 2019

Thanks a lot for your contribution! It's very much appreciated :)!

@Byron Byron added this to the v2.1.12 - Bugfixes milestone Jul 6, 2019
@Byron
Copy link
Member

Byron commented Jul 6, 2019

I am closing this PR as due to me apparently making a mistake while merging things locally, Github is unable to see the branch has actually been merged. Your commit is here 41b9cea

@Byron Byron closed this Jul 6, 2019
@ninloot
Copy link
Contributor Author

ninloot commented Jul 16, 2019 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants