Skip to content

Remove duplicate license parameter #958

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

blag
Copy link
Contributor

@blag blag commented Nov 6, 2019

The Python packaging specifications indicate that the license parameter to setup() should be used in one of the following cases:

  • the license is not a selection from the “License” Trove classifiers
  • to specify a particular version of a license which is named via the Classifier field
  • to indicate a variation or exception to such a license

This PR removes the explicit license parameter since the usage for this project does not fit any of those cases and it makes it more difficult to use tools like pip-licenses since it is not consistent with other projects that just have License :: OSI Approved :: BSD License as one of their trove classifiers.

Please note that this does not change the license of the project in any way, and since this project already has a License :: OSI Approved :: BSD License trove classifier the license parameter is redundant.

@Byron Byron merged commit d17c2f6 into gitpython-developers:master Nov 7, 2019
@Byron Byron added this to the v3.0.5 - Bugfixes milestone Nov 7, 2019
@Byron
Copy link
Member

Byron commented Nov 7, 2019

Thanks a lot for your contribution! It's much appreciated.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants