refactor: replace Default for clarity
#2260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
commented
Jun 7, 2024
| @@ -248,7 +248,7 @@ mod test { | |||
| text: &str, | |||
| text_area_width: u16, | |||
| ) -> (Vec<String>, Vec<u16>) { | |||
| let style = Default::default(); | |||
| let style = ratatui::style::Style::default(); | |||
There was a problem hiding this comment.
I wasn't sure if Style::default(), with an additional import at the top, would be preferable here.
|
@extrawurst are you open to this change? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces
Default::default()with T::default() where T is the type of the default value, to make it more clear which default we are using.I followed the checklist:
make checkwithout errors