Remove unnecessary try catch

gladly-team · Jun 28, 2024 · ed69ee7 · ed69ee7
1 parent d23c46c
commit ed69ee7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/src/__tests__/initFirebaseClientSDK.test.ts b/src/__tests__/initFirebaseClientSDK.test.ts
@@ -30,12 +30,15 @@ describe('initFirebaseClientSDK', () => {
     expect.assertions(1)
     const initFirebaseClientSDK = require('src/initFirebaseClientSDK').default
     initFirebaseClientSDK()
-    expect(mockInitializeApp).toHaveBeenCalledWith({
-      apiKey: 'fakeAPIKey123',
-      authDomain: 'my-example-app.firebaseapp.com',
-      databaseURL: 'https://my-example-app.firebaseio.com',
-      projectId: 'my-example-app-id',
-    })
+    expect(mockInitializeApp).toHaveBeenCalledWith(
+      {
+        apiKey: 'fakeAPIKey123',
+        authDomain: 'my-example-app.firebaseapp.com',
+        databaseURL: 'https://my-example-app.firebaseio.com',
+        projectId: 'my-example-app-id',
+      },
+      undefined
+    )
   })
 
   it('does not call firebase.initializeApp if Firebase already has an initialized app', () => {

diff --git a/src/useFirebaseUser.ts b/src/useFirebaseUser.ts
@@ -176,16 +176,13 @@ const useFirebaseUser = () => {
     }
 
     // https://firebase.google.com/docs/reference/js/firebase.auth.Auth#onidtokenchanged
-    try {
-      const { firebaseClientAppName } = getConfig()
-      const app = getApp(firebaseClientAppName)
-      const unsubscribe = onIdTokenChanged(getAuth(app), onIdTokenChange)
-      return () => {
-        unsubscribe()
-        isCancelled = true
-      }
-    } catch (error) {
-      throw error
+
+    const { firebaseClientAppName } = getConfig()
+    const app = getApp(firebaseClientAppName)
+    const unsubscribe = onIdTokenChanged(getAuth(app), onIdTokenChange)
+    return () => {
+      unsubscribe()
+      isCancelled = true
     }
   }, [])