-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Let user specify the firebase app name #716
Let user specify the firebase app name #716
Conversation
@MvRemmerden is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
@kmjennison I think this PR might be ready, would you mind approving it to be deployed on Vercel so we can see whether any of the checks fail? 🙂 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MvRemmerden Thanks for this! The approach looks good. Could you investigate the failing tests?
@kmjennison I might need some help here. It looks like the problem is due to this change here: https://github.com/gladly-team/next-firebase-auth/pull/716/files#diff-40051885c173eb84152e58b7e9f3cbac7bd1e5d9de2520a1bd2a4253b4a6b9a0R108 I'm not sure if we just need to adapt the test to ensure that the app is initialized before, or if there is a bug here in the actual code. Would you mind having a look yourself? |
Update: I think I got it working, it might have just been missing mocked configs in the tests, everything is passing now ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change needed and otherwise looks good.
Co-authored-by: Kevin Jennison <kevin.jennison1@gmail.com>
@kmjennison Awesome, committed, back to you 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your work on this!
No description provided.