Perform name matching locally #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't great code, but this is a first pass at performing name matching locally, rather than via the Datatracker API. I've kept "names" distinct from "identifiers" because they aren't necessarily unique (whereas identifiers are treated as unique).
person_with_name_emailis essentiallyperson_from_name_emailfrom DatatrackerExt, but modified to look for names in the participant database, rather than the Datatracker. The matching is essentially the same (though not exactly), and still relies on hitting an exact match -- good enough for now, but something that can be tweaked.