Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gleam dev idea #3831

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gleam dev idea #3831

wants to merge 1 commit into from

Conversation

lpil
Copy link
Member

@lpil lpil commented Nov 14, 2024

What do you think?

Rendered

@lpil lpil added the discussion The approach has not yet been decided label Nov 14, 2024
@schurhammer
Copy link
Contributor

gleam fix could rename test to dev if it contains Gleam code.

I think we better not do this.

  1. It can break the project
  2. Its very easy to do manually

Other than that, sounds good to me.

@strawmelonjuice
Copy link

Oh yes this makes that a lot clearer --must say the proposal cleared it up for me...--, if this is doable without considerable load I'd say this is a great idea?

@lpil
Copy link
Member Author

lpil commented Nov 14, 2024

That seems reasonable @schurhammer. It is easy for them to do, as you say.

@lpil lpil marked this pull request as draft November 14, 2024 21:31
@massivefermion
Copy link
Contributor

massivefermion commented Dec 31, 2024

Why get rid of test? I think test code is the most probable thing this directory is going to be used for, so it deserves a directory of its own. You can just make the compiler recognize the dev directory if it's there. Getting rid of the test directory in the project and constantly explaining to newcomers that the tests should be in the dev directory would be even more confusing than the problem this proposal is trying to solve!

@lpil
Copy link
Member Author

lpil commented Jan 2, 2025

It's not a problem in other mainstream ecosystems such as Java and JavaScript, so I don't think it would be a problem for Gleam.

@inoas-nbw
Copy link

We ran into this problem recently in elixir projects where we had test data that was required for testing the library integration by library consumers and put it into test... which was not shipped. If it had been named dev it would have been more clear and src/test would have been used or an elixir equivalent.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
discussion The approach has not yet been decided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants