Display Gleam version number on playground navbar #10
Conversation
There was a problem hiding this comment.
I dig it! Could you make it so gleam run and the compiler downloader script work without setting environment variables please. It doesn't vary per environment so it should be derived from the code, not the environment.
Ideally the CI fails if its version doesn't match the version they use, but I'm happy for that not to be part of your contribution if you prefer.
|
So I updated the code to read from a Not 100% sure if this is what you want or not. If it's not I can take all of the fancy code for reading the version number out and just leave the hard-coded one in and add a line to the README to update it in that spot |
| fn read_gleam_version() -> snag.Result(String) { | ||
| gleam_version | ||
| |> simplifile.read() | ||
| |> file_error("Failed to read glema version at path " <> gleam_version) | ||
| } |
There was a problem hiding this comment.
Note that at runtime you may be able to use this as well build/dev/javascript/gleam_version.
There was a problem hiding this comment.
Actually nevermind, that would be what gleam version ran on the host to do the precompiling.
The compiler version itself would be in playground/wasm-compiler/package.json
|
Oops sorry, just re-added! |
After wanting to try out the new Gleam version but being unsure whether or not the playground had been updated yet I thought it would be a good idea to include Gleam version being used somewhere within the UI. If there is a more clear place to put it please let me know and I can adjust the PR accordingly.
Additionally I updated the code to read the gleam version from the command line both for downloading the correct version of the Gleam compiler and for displaying the version on the frontend. This way the two are never out of sync, but it does mean that the variable will needed to be added to GitHub.
I also had to change the
targetto Erlang from JavaScript. As far as I can tell this should be fine since it seems like the action's environment is already pulling in Erlang.As a bit of an aside, I was wondering if there is any use in letting users somehow choose which version of the Gleam compiler is being used for the playground. If that seems like a worthwhile feature I'd be happy to open up an issue for further discussion, and take on development as well.