Use 'SHOW CREATE ALL TABLES' instead of cockroach dump #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammohammed
changed the title
adammohammed
force-pushed
the
support-for-v21.2-and-newer
branch
from
c0ab29f to
9a38a11
Compare
adammohammed
commented
Jun 7, 2022
|
LGTM, please rebase on top of master as it already includes the fix proposed in #41. Thanks for the contribution, once rebased I will review ASAP. |
adammohammed
force-pushed
the
support-for-v21.2-and-newer
branch
from
9a38a11 to
2791dc9
Compare
|
@glerchundi Do you have time to take another pass at this? |
rwrz
reviewed
Dec 20, 2022
| all = bytes.Replace(all, []byte("create_statement"), []byte{}, -1) | ||
| all = bytes.Replace(all, []byte("\"CREATE"), []byte("CREATE"), -1) | ||
| all = bytes.Replace(all, []byte(";\""), []byte(";"), -1) | ||
| f.buf = bytes.NewBuffer(all) |
There was a problem hiding this comment.
I had issues with DOUBLE DOUBLE QUOTES.
To fix, I had to replace "" with ", like this:
all = bytes.Replace(all, []byte("\"\""), []byte("\""), -1)
In CRDB v21.2 and newer `cockroach dump` is removed and the docs say to use `SHOW CREATE ALL TABLES`. This isn't quite a drop in replacement since it dumps some other non-sql information out. Signed-off-by: Adam Mohammed <admohammed@equinix.com>
Signed-off-by: Adam Mohammed <admohammed@equinix.com>
Signed-off-by: Adam Mohammed <admohammed@equinix.com>
adammohammed
force-pushed
the
support-for-v21.2-and-newer
branch
from
2791dc9 to
dffb9a3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CRDB v21.2 and newer
cockroach dumpis removed and the docs say to useSHOW CREATE ALL TABLES. This isn't quite a drop in replacement since it dumps some other non-sql information out.This PR builds off of #41 and filters out the non-sql bits so that the generated tests still work.
Should fix #43 - but not sure if this is backwards compatible with previous CRDB releases.