Move the addition of command affects to stale settings from send_pend… #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to receive As mentioned in issue glikely#170, adding a command's affects to stale_settings as the command is being sent causes the VISCA controller to generate an inquiry for the stale setting before the camera has had a chance to change the setting. This was discovered particularly for Power On/Off setting. By moving the code to the receive function after the camera sends a completion message for the command, we are assured that the result of the inquiry to refresh the stale setting will be the current setting. Reported By: GeNTooGeek Signed-off-by: GeNTooGeek <gentoogeek@3g5g.ca>
Currently implementation of set_settings doesn't proect the changing of the wb_mode settings with an if statement to verify that the new settings include a new wb_mode. The ended up generating extra requests for wb_mode when only requesting the change in power setting. Added the if statement to protect it. Reported by: GeNTooGeek Signed-off-by: GeNTooGeek <gentoogeek@3g5g.ca>
I wanted to be able to automatically turn my camera on and off with the use of Advanced Scene Switcher, but I noticed that the PTZ Action Source was missing Power On/Off as an action option. Added the required code to add the items in the source properties, and other code to push the request to the device. I followed the way the movement actions are implemented. I later noticed that the PTZ Controls dialog includes a context menu option to turn on and off the camera's power. While my implementation of the power actions is not done the same way as the way the context menu is implemented, the settings for the camera are properly updated after the PTZ Action is completed, so they play nicely together. Reported by: GeNTooGeek Signed-off-by: GeNTooGeek <gentoogeek@3g5g.ca>
|
Ah, I am still learning to work with GitHub and I didn't realize that all of my commits would show up under the one PR. I have a few other things that I will be adding in my own repository, but I will create a new branch, so hopefully the new things don't end up in this PR. |
Stop using deprecated obs_frontend_add_dock()
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing to receive
As mentioned in issue #170, adding a command's affects to stale_settings as the command is being sent causes the VISCA controller to generate an inquiry for the stale setting before the camera has had a chance to change the setting. This was discovered particularly for Power On/Off setting.
By moving the code to the receive function after the camera sends a completion message for the command, we are assured that the result of the inquiry to refresh the stale setting will be the current setting.
Reported By: GeNTooGeek
Signed-off-by: GeNTooGeek gentoogeek@3g5g.ca