Merge pull request #1456 from glimmerjs/use-real-qunit-types

Can we use the real @types/qunit?
glimmerjs · Oct 24, 2023 · 2b6952e · 2b6952e
2 parents ac36624 + c9be694
commit 2b6952e
Show file tree

Hide file tree

Showing 14 changed files with 57 additions and 947 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -78,5 +78,16 @@ module.exports = {
         'n/no-extraneous-import': 'warn',
       },
     },
+
+    // QUnit is a weird package, and there are some issues open about fixing it
+    // - https://github.com/qunitjs/qunit/issues/1729
+    // - https://github.com/qunitjs/qunit/issues/1727
+    // - https://github.com/qunitjs/qunit/issues/1724
+    {
+      files: ['**/*-test.ts', '**/{test,integration-tests}/**/*.ts'],
+      rules: {
+        '@typescript-eslint/unbound-method': 'off',
+      },
+    },
   ],
 };
diff --git a/package.json b/package.json
@@ -71,7 +71,7 @@
     "@types/eslint": "^8.37.0",
     "@types/node": "^18.16.6",
     "@types/preval.macro": "^3.0.0",
-    "@types/qunit": "workspace:^",
+    "@types/qunit": "^2.19.7",
     "@typescript-eslint/eslint-plugin": "^5.59.5",
     "@typescript-eslint/parser": "^5.59.5",
     "amd-name-resolver": "^1.3.1",

diff --git a/packages/@glimmer-workspace/.eslintrc.cjs b/packages/@glimmer-workspace/.eslintrc.cjs
@@ -16,5 +16,15 @@ module.exports = {
       plugins: ['@glimmer-workspace'],
       extends: ['plugin:@glimmer-workspace/recommended'],
     },
+    // QUnit is a weird package, and there are some issues open about fixing it
+    // - https://github.com/qunitjs/qunit/issues/1729
+    // - https://github.com/qunitjs/qunit/issues/1727
+    // - https://github.com/qunitjs/qunit/issues/1724
+    {
+      files: ['**/*-test.ts', '**/{test,integration-tests}/**/*.ts'],
+      rules: {
+        '@typescript-eslint/unbound-method': 'off',
+      },
+    },
   ],
 };
diff --git a/packages/@glimmer-workspace/integration-tests/lib/setup-harness.ts b/packages/@glimmer-workspace/integration-tests/lib/setup-harness.ts
@@ -7,6 +7,7 @@ export async function setupQunit() {
   await import('qunit/qunit/qunit.css');
 
   const runner = autoRegister();
+  // @ts-expect-error qunit types don't expose "reporters"
   const tap = qunit.reporters.tap;
   tap.init(runner, { log: console.info });
 

diff --git a/packages/@glimmer-workspace/integration-tests/package.json b/packages/@glimmer-workspace/integration-tests/package.json
@@ -31,7 +31,7 @@
   },
   "devDependencies": {
     "@glimmer/local-debug-flags": "workspace:^",
-    "@types/qunit": "workspace:^",
+    "@types/qunit": "^2.19.7",
     "@types/js-reporters": "workspace:^"
   },
   "scripts": {

diff --git a/packages/@glimmer/.eslintrc.cjs b/packages/@glimmer/.eslintrc.cjs
@@ -16,5 +16,15 @@ module.exports = {
       plugins: ['@glimmer-workspace'],
       extends: ['plugin:@glimmer-workspace/recommended'],
     },
+    // QUnit is a weird package, and there are some issues open about fixing it
+    // - https://github.com/qunitjs/qunit/issues/1729
+    // - https://github.com/qunitjs/qunit/issues/1727
+    // - https://github.com/qunitjs/qunit/issues/1724
+    {
+      files: ['**/*-test.ts', '**/{test,integration-tests}/**/*.ts'],
+      rules: {
+        '@typescript-eslint/unbound-method': 'off',
+      },
+    },
   ],
 };
diff --git a/packages/@glimmer/node/package.json b/packages/@glimmer/node/package.json
@@ -9,7 +9,7 @@
     "@simple-dom/document": "^1.4.0"
   },
   "devDependencies": {
-    "@types/qunit": "workspace:^",
+    "@types/qunit": "^2.19.7",
     "@glimmer/compiler": "workspace:^",
     "@glimmer-workspace/build-support": "workspace:^"
   },
@@ -30,4 +30,4 @@
       "default": "./dist/index.js"
     }
   }
-}
+}
diff --git a/packages/@glimmer/runtime/package.json b/packages/@glimmer/runtime/package.json
@@ -34,7 +34,7 @@
     "@glimmer/local-debug-flags": "workspace:^",
     "@glimmer/opcode-compiler": "workspace:^",
     "@glimmer/debug": "workspace:^",
-    "@types/qunit": "workspace:^",
+    "@types/qunit": "^2.19.7",
     "@glimmer-workspace/build-support": "workspace:^"
   },
   "scripts": {

diff --git a/packages/@glimmer/syntax/package.json b/packages/@glimmer/syntax/package.json
@@ -11,7 +11,7 @@
   },
   "devDependencies": {
     "@glimmer/local-debug-flags": "workspace:^",
-    "@types/qunit": "workspace:^",
+    "@types/qunit": "^2.19.7",
     "@glimmer-workspace/build-support": "workspace:^"
   },
   "scripts": {

diff --git a/packages/@glimmer/util/package.json b/packages/@glimmer/util/package.json
@@ -10,7 +10,7 @@
   },
   "devDependencies": {
     "@glimmer/local-debug-flags": "workspace:^",
-    "@types/qunit": "workspace:^",
+    "@types/qunit": "^2.19.7",
     "@glimmer-workspace/build-support": "workspace:^"
   },
   "main": "index.ts",