New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expose `voidMap` and `visitorKeys` #1465

Closed

fisker opened this issue Oct 27, 2023 · 4 comments · Fixed by #1467

Contributor

fisker commented Oct 27, 2023

Prettier is using them

https://github.com/prettier/prettier/blob/e682577c08e83c0ab272fc73ad1633883ad5d1a5/src/language-handlebars/visitor-keys.evaluate.js#L1
https://github.com/prettier/prettier/blob/e682577c08e83c0ab272fc73ad1633883ad5d1a5/src/language-handlebars/html-void-elements.evaluate.js#L1

These sub paths are removed in v0.85, can we export them?

Contributor

NullVoxPopuli commented Oct 27, 2023 •

edited

Loading

looks like they may still be available from @glimmer/syntax, just here:

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAKjgQwM51TArgMx3HKCEOAcgAEBzAG1BAFMoB6VATwDsZkAPUgbgBQAzLhwA6AIIBlACoA3AIxi5wVMBjQA0vVaogA

but according to https://www.npmjs.com/package/@glimmer/syntax?activeTab=code
it's not exported.

thanks for reporting!

NullVoxPopuli added a commit that referenced this issue


          visitorKeys is needed for prettier, resolves #1465

ef905f9

NullVoxPopuli mentioned this issue

visitorKeys is needed for prettier #1467

Merged

Contributor Author

fisker commented Oct 27, 2023 •

edited

Loading

Thanks for the quick fix, we also need voidMap.

Contributor Author

fisker commented Oct 27, 2023

Or an array of void element tags, even better.

Contributor

NullVoxPopuli commented Oct 27, 2023

you're right! added. thanks!

NullVoxPopuli closed this as completed in #1467

# for free to join this conversation on GitHub. Already have an account? # to comment