Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ItemEntities with .setNeverPickUp() can be picked up. #20

Closed
Micaxs opened this issue Jul 8, 2023 · 1 comment
Closed

ItemEntities with .setNeverPickUp() can be picked up. #20

Micaxs opened this issue Jul 8, 2023 · 1 comment
Labels
priority: normal this issue does not break any critical functionality - it must be adressed, but not immediately status: confirmed this issue is reproducible or otherwise confirmed to exist status: scheduled the resolution of this issue is scheduled for the next release type: bug this issue breaks or otherwise adversely affects functionality

Comments

@Micaxs
Copy link

Micaxs commented Jul 8, 2023

Hello,

I noticed there is a issue where when a mod adds an itementity to the world and set this item with .setNerverPickUp(), the item can still be picked up with this mod when the config rightClickPickup": true is set.

This shouldn't be the case as it breaks several mods where an item is being diplayed but shouldn't be allowed to be picked up or interacted with.
gliscowo added a commit that referenced this issue Jan 5, 2024
@gliscowo
1.20.4 and fixes
fe78f74 
 - disable quick item movement into item filter slots (fixes #27)
 - disallow picking up items with infinite pickup levels (fixes #20)
@gliscowo gliscowo added type: bug this issue breaks or otherwise adversely affects functionality priority: normal this issue does not break any critical functionality - it must be adressed, but not immediately status: confirmed this issue is reproducible or otherwise confirmed to exist status: scheduled the resolution of this issue is scheduled for the next release labels Jan 11, 2024
@gliscowo
Copy link
Owner

Thanks for reporting this, a fix has now been released in 0.2.2
Cheers

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
priority: normal this issue does not break any critical functionality - it must be adressed, but not immediately status: confirmed this issue is reproducible or otherwise confirmed to exist status: scheduled the resolution of this issue is scheduled for the next release type: bug this issue breaks or otherwise adversely affects functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Micaxs @gliscowo