as_steps support in profile viewer #309
Conversation
There was a problem hiding this comment.
As mentioned in glue-viz/glue#2292 (comment), I think we should instead be implementing the logic of converting the profile into a stepped profile in the bqplot layer artist so that it would be analogous to the fact that this conversion is done in the layer artist for Matplotlib (in fact it is done inside Matplotlib because of the drawstype='steps' option).
| @@ -6,5 +6,8 @@ | |||
| <div> | |||
| <v-select label="attribute" :items="attribute_items" v-model="attribute_selected" hide-details /> | |||
| </div> | |||
| <div> | |||
| <v-switch label="Plot as steps/histogram" v-model="as_steps" /> | |||
There was a problem hiding this comment.
I would avoid using the terminology 'histogram' here, maybe just use 'steps'
|
Just noticed that this seems to break when adding a subset (within the bqplot steps logic)... we'll need to fix that before merging/releasing. |
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 89.14% 89.16% +0.02%
==========================================
Files 86 86
Lines 4275 4284 +9
==========================================
+ Hits 3811 3820 +9
Misses 464 464
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* this can occur when first creating a subset, for example
kecnry
force-pushed
the
profile-viewer-as-steps
branch
from
60958e6 to
3cd9d31
Compare
|
Sorry this fell off the radar for a little while. I rebased, confirmed this works with glue 1.3+, and set that as a requirement in setup.cfg. |
Description
This accompanies glue-viz/glue#2292 to expose the
as_stepsswitch in the layer options widget, and handling togglingas_stepsin the bqplot layer artist for the profile viewer. The actual binning logic is adopted from https://github.com/astropy/specutils/blob/main/specutils/spectra/spectral_axis.py#L42.