Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove debug panel in ipyvolume viewers #457

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Carifio24
Copy link
Member

This PR removes the side debug panel in the ipyvolume viewers. Thanks to @maartenbreddels for the tip on how to do this.

This also increases the default size of the figure itself from 400 -> 600px, as I couldn't see the entire bounding box with a 400px width. Happy to increase the size further if desired.

@Carifio24
Copy link
Member Author

Just for context, here's what the view looked like at 400px:
Screenshot from 2024-08-01 15-40-44

and at 600px:
Screenshot from 2024-08-01 15-41-06

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (488287d) to head (1d9c74e).
Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files          90       90           
  Lines        5223     5224    +1     
=======================================
+ Hits         4494     4495    +1     
  Misses        729      729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@astrofrog astrofrog merged commit e1a42df into glue-viz:main Aug 6, 2024
26 checks passed
@astrofrog astrofrog added the bug Something isn't working label Aug 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working ipyvolume
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants