Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make limits cache private for serialization #474

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Carifio24
Copy link
Member

This PR resolves #471 by using the first approach mentioned in that issue - changing limits_cache -> _limits_cache so that it isn't serialized. As mentioned in #471, this matches the structure of the VisPy viewer states.

I suppose this is a breaking change as it's changing the name of the class member. I would imagine that there aren't any clients directly manipulating the limits cache, but if there are I'm happy to use the second approach mentioned in the issue instead.

@Carifio24 Carifio24 requested a review from astrofrog November 1, 2024 18:17
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.03%. Comparing base (54499a8) to head (ee93916).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
glue_jupyter/common/state3d.py 57.14% 3 Missing ⚠️
glue_jupyter/common/tests/test_state3d.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   86.07%   86.03%   -0.05%     
==========================================
  Files          90       91       +1     
  Lines        5242     5269      +27     
==========================================
+ Hits         4512     4533      +21     
- Misses        730      736       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog merged commit 2a1d152 into glue-viz:main Nov 1, 2024
24 of 26 checks passed
@astrofrog astrofrog added the bug Something isn't working label Nov 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ipyvolume viewer states are not JSON-serializable
2 participants