Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use last focused/resized view to determine shape of BqplotImageView #475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iisakkirotko
Copy link

@iisakkirotko iisakkirotko commented Dec 11, 2024

Pull Request Template

Description

Instead of always using the lowest cid view to determine the aspect ratio / shape of a Bqplot image viewer, use the last focused / resized one. focused_at describes the time that the window of that view was last focused, while resized_at describes when each viewer was last resized, so this way distortion from resizing based on a view in a popout window will be fixed once the original window is brought into focus.

Needs glue-viz/bqplot-image-gl#112 to work. Let me know if you need this to use the old behaviour as a fallback with previous versions of bqplot-image-gl.

TODO:

@maartenbreddels
Copy link
Collaborator

Let me know if you need this to use the old behaviour as a fallback with previous versions of bqplot-image-gl.

I think it's fine like this, if we also bump

bqplot-image-gl>=1.5.0

Otherwise some people might get the old behaviour.

@maartenbreddels
Copy link
Collaborator

We can use version 1.6.0 now (https://pypi.org/project/bqplot-image-gl/1.6.0/)

@iisakkirotko iisakkirotko force-pushed the fix-use-last-focused-resized-view-for-shape-bqplotimageview branch from 9625a7c to 1630099 Compare December 27, 2024 10:36
@iisakkirotko iisakkirotko marked this pull request as ready for review January 21, 2025 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants