Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update 1D Profile viewer to use wcsaxes - Add slice function to 1D Profile viewer with sliders to select point #2248

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Nov 9, 2021

Rebase and update of #2167

As far as I can tell it this PR is meant to add:

Forces WCSAxes to be used for the .1D Profile viewer
A new slice function that allows a user to get the 1D data at a point
The slice function uses a new widget to allow selection of the point via two sliders

TODO:

  • Slice sliders show up on x-axis change for other functions (go from slice to sum (or others), change x-axis, they appear)
  • Fix tests
  • WCS names are missing from x-axis dropdown, they are there on main.
  • Profile is not displaying data when I change WCS axis name without moving the slider or normalizing the data

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #2248 (eed2eea) into main (1c71837) will decrease coverage by 0.23%.
The diff coverage is 79.89%.

❗ Current head eed2eea differs from pull request most recent head 586d194. Consider uploading reports for the commit 586d194 to get more accurate results

@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
- Coverage   88.15%   87.92%   -0.24%     
==========================================
  Files         247      249       +2     
  Lines       23316    23438     +122     
==========================================
+ Hits        20554    20607      +53     
- Misses       2762     2831      +69     
Impacted Files Coverage Δ
glue/conftest.py 63.75% <ø> (+0.65%) ⬆️
glue/viewers/image/qt/profile_viewer_tool.py 23.91% <ø> (+0.50%) ⬆️
glue/viewers/image/qt/slice_widget.py 71.87% <50.00%> (-0.76%) ⬇️
glue/viewers/profile/qt/options_widget.py 76.59% <54.54%> (-23.41%) ⬇️
glue/viewers/profile/qt/slice_widget.py 70.37% <70.37%> (ø)
glue/viewers/profile/state.py 94.90% <89.13%> (-4.12%) ⬇️
glue/app/qt/layer_tree_widget.py 80.59% <100.00%> (ø)
glue/core/data.py 91.66% <100.00%> (ø)
glue/utils/wcs.py 100.00% <100.00%> (ø)
glue/viewers/common/qt/data_slice_widget.py 83.21% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c71837...586d194. Read the comment docs.

@nabobalis nabobalis force-pushed the 1dprofile_wcs branch 3 times, most recently from 95b08fb to 3193d73 Compare February 7, 2022 22:01
Comment on lines +209 to +212
# TODO: This should not be here.
# I can not work out how to get this to be set at initialisation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs fixing, I just have yet to work it out yet.

@nabobalis nabobalis force-pushed the 1dprofile_wcs branch 4 times, most recently from a3027f3 to bcee99a Compare April 1, 2022 21:25
@nabobalis nabobalis changed the title Update 1D Profile viewer to use wcsaxes for plotting and add sliders Update 1D Profile viewer to use wcsaxes - Add slice function to 1D Profile viewer with sliders to select point May 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant