Add the ability to specify a random subset size for computing histogram #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ams, and expose as a viewer state property in the histogram viewer
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Mar 20, 2024
but does not seem to work [ci skip]
10 tasks
pllim
reviewed
Mar 20, 2024
|
|
||
| with NumpyRNGContext(12345): | ||
|
|
||
| data = Data(x=np.random.uniform(0, 10, 1024**2), y=np.ones(1024 ** 2)) |
There was a problem hiding this comment.
I don't see a test for 2D image like how Jdaviz would store it. We have a 2D array under one component. Here, you store each dimension as a separate component. I don't think it is equivalent?
Since we do not use histogram viewer directly in Jdaviz, I am trying to emulate this calculation directly over at spacetelescope/jdaviz#2763 but without success. There must be some subtlety I am missing. Are you able to have a look over there and tell me if I went down the wrong rabbit hole?
Cami has a 8GB test image if you need one, if she is willing to share with you.
9 tasks
…e for some arrays (e.g. a cutout of a larger image) this causes a copy
pllim
approved these changes
Apr 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide a long-term solution for issues such as spacetelescope/jdaviz#2735 where a histogram doesn't have to be exact.