Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

User confirmation dialog to decide whether to save a file has lacks title and icon #459

Closed
Oliver-Loeffler opened this issue Jan 16, 2022 · 0 comments · Fixed by #477
Closed

User confirmation dialog to decide whether to save a file has lacks title and icon #459

Oliver-Loeffler opened this issue Jan 16, 2022 · 0 comments · Fixed by #477
Labels
bug Something isn't working

Comments

@Oliver-Loeffler
Copy link
Collaborator

All Scene Builder dialogs and windows have a common icon.
Windows and dialogs usually have a name.

Expected Behavior

The dialog where the user is asked to save a file should show the Scene Builder icon.
The dialog should have a name such as "Scene Builder".

Current Behavior

The dialog has only the standard icon provided by platform.

Steps to Reproduce

  • Open Scene Builder
  • Create a new FXML, add a Button
  • Click menu View / Show Sample Controller Skeleton - this dialog has the proper application icon
  • Close the dialog
  • Close Scene Builder
  • Scene Builder will open a dialog to ask whether a file shall be saved or not -> this dialog has not the Scene Builder icon, the dialog has no name/title

Your Environment

OS: Windows 10 Pro
Version: 21H2 19044.1466

Screenshots

Missing dialog icon:
IconMissingAtFileSaveConfirmationDialog

Expected:
IconsAsExpected

UpdateCheck
@Oliver-Loeffler Oliver-Loeffler added the bug Something isn't working label Jan 16, 2022
@Oliver-Loeffler Oliver-Loeffler mentioned this issue Jan 21, 2022
Merged
3 tasks
AlmasB pushed a commit that referenced this issue Jan 22, 2022
@Oliver-Loeffler
AbstractModalDialog shows correct application icon #459 (#477)
50de6a0 
* Added title to save-or-not dialog.

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>
paul-court pushed a commit to paul-court/scenebuilder that referenced this issue Jan 28, 2022
@Oliver-Loeffler
AbstractModalDialog shows correct application icon gluonhq#459 (gluon…
9363118 
…hq#477)

* Added title to save-or-not dialog.

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AbstractModalDialog shows correct application icon #459 Oliver-Loeffler/scenebuilder
1 participant
@Oliver-Loeffler