#232 Added logging when exploring libraries (jars or folders) #234
Conversation
… including refactoring of JarExplorer and FolderExplorer gluonhq#233 Don’t scan JavaFX jars
jperedadnr
added
enhancement
|
That seems good to me. |
kit/src/main/java/com/oracle/javafx/scenebuilder/kit/library/BuiltinLibrary.java
Outdated
Show resolved
Hide resolved
kit/src/main/resources/com/oracle/javafx/scenebuilder/kit/i18n/SceneBuilderKit.properties
Show resolved
Hide resolved
|
|
||
| import javafx.fxml.FXMLLoader; | ||
| import javafx.scene.Node; | ||
|
|
||
| /** | ||
| * | ||
| * | ||
| */ |
There was a problem hiding this comment.
This would be a good opportunity to add some Javadoc to the classes explaining what these classes do.
There was a problem hiding this comment.
This will require some time, probably best for a follow-up.
|
Given that a year and a half has passed, it seems to me like @jperedadnr isn't likely to address the comments on the merge request. Would it be possible to just merge this and then someone with write access to the gluonhq repo could make the suggested changes after the merge? The suggested changes are quite small. |
|
@nathanwonnacott Sorry, it took some time... but I addressed the comments. We'll merge soon. |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2017, Gluon and/or its affiliates. | |||
| * Copyright (c) 2019, 2020, Gluon and/or its affiliates. | |||
There was a problem hiding this comment.
Shouldn't this change be "2017, 2020, Gluon" ?
There was a problem hiding this comment.
No, that file was actually created in 2019, in this PR #228
including refactoring of JarExplorer and FolderExplorer
#233 Don’t scan JavaFX jars
This PR adds some really useful information to the console when importing custom libraries, mainly focused on library developers that never know why Scene Builder doesn't want to import their controls.
The logging level is set to
info, but in most cases, a regular user will launch Scene Builder from the executable, without a visible console.