test: Migrated existing tests to JUnit5 API - removed JUnit4 (2/2) #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliver-Loeffler
changed the title
AlmasB
reviewed
Jan 22, 2022
...racle/javafx/scenebuilder/kit/editor/panel/library/manager/DialogListItemComparatorTest.java
Show resolved
Hide resolved
Oliver-Loeffler
commented
Jan 22, 2022
kit/src/test/java/com/oracle/javafx/scenebuilder/kit/fxom/FXMLPropertiesDisablerTest.java
Show resolved
Hide resolved
kit/src/test/java/com/oracle/javafx/scenebuilder/kit/fxom/FXOMDocumentTest.java
Outdated
Show resolved
Hide resolved
.../test/java/com/oracle/javafx/scenebuilder/kit/fxom/FXMLPropertiesDisablerVariationsTest.java
Show resolved
Hide resolved
kit/src/test/java/com/oracle/javafx/scenebuilder/kit/skeleton/SkeletonFileNameProposalTest.java
Show resolved
Hide resolved
...racle/javafx/scenebuilder/kit/editor/panel/library/manager/DialogListItemComparatorTest.java
Show resolved
Hide resolved
Oliver-Loeffler
changed the title
AlmasB
changed the title
3 tasks
AlmasB
reviewed
Feb 6, 2022
|
|
||
| String generatedFxml = classUnderTest.getFxmlText(false); | ||
| assertTrue(generatedFxml.contains("useSystemMenuBar=\"true\"")); | ||
| } | ||
|
|
||
| @Test | ||
| public void that_useSystemMenuBarProperty_not_modified_on_Linux_and_Windows() throws Exception { | ||
| assumeTrue("Windows or Linux", Set.of(OS.LINUX, OS.WINDOWS).contains(OS.get())); | ||
| assumeTrue(Set.of(OS.LINUX, OS.WINDOWS).contains(OS.get()), "Windows or Linux"); |
There was a problem hiding this comment.
Perhaps adding disabled on os or enabled on os would be clearer?
There was a problem hiding this comment.
Yes, very good idea. Much better than this.
|
|
||
| String generatedFxml = classUnderTest.getFxmlText(false); | ||
| assertTrue(generatedFxml.contains("useSystemMenuBar=\"true\"")); | ||
| } | ||
|
|
||
| @Test | ||
| public void that_useSystemMenuBarProperty_is_disabled_on_MacOS() throws Exception { | ||
| assumeTrue("MacOS", OS.get() == OS.MAC); |
There was a problem hiding this comment.
Perhaps adding disabled on os or enabled on os would be clearer?
There was a problem hiding this comment.
JUnit4 will no longer work.
3 tasks
AlmasB
approved these changes
Feb 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to effort to modernize test infrastructure.
All existing tests migrated to JUnit5 API.
This is the follow up to PR #478
Issue
Fixes #449
Progress