refactor: Replaced print stack trace calls with Logger #528
Conversation
| @@ -825,7 +829,7 @@ private void keyPressedOnGlassLayer(KeyEvent e) { | |||
| if (RelocateSelectionJob.isSelectionMovable(contentPanelController.getEditorController())) { | |||
| activateGesture(new MoveWithKeyGesture(contentPanelController), e); | |||
| } else { | |||
| System.out.println("Selection is not movable"); | |||
| Logger.getLogger(getClass().getName()).log(Level.INFO, "Selection is not movable"); | |||
| } catch(IOException x) { | ||
| x.printStackTrace(); | ||
| } catch(IOException e) { | ||
| Logger.getLogger(getClass().getName()).log(Level.WARNING, "Failed to close URL classloader: ", e); |
| } | ||
| return null; | ||
| }); | ||
| if (setStaticLoadMethod != null) { | ||
| try { | ||
| setStaticLoadMethod.invoke(loader, staticLoad); | ||
| } catch (IllegalAccessException | InvocationTargetException e) { | ||
| e.printStackTrace(); | ||
| Logger.getLogger(ReflectionUtils.class.getName()).log(Level.WARNING, "Failed to invoke method setStaticLoad: ", e); |
| } | ||
| } catch (MalformedURLException e) { | ||
| e.printStackTrace(); | ||
| Logger.getLogger(AppSettings.class.getName()).log(Level.WARNING, "Failed to construct latest version info URL: ", e); |
There was a problem hiding this comment.
Isn't it better to create a single static final instance of the Logger for the class?
There was a problem hiding this comment.
Would only do that if there are multiple calls at various places inside a class.
Would not create that if it is only an exception handling.
Opposite would be for example when logging state of object or node tree modifications, there I'd hold a (private static final) logger instance for this particular class.
There was a problem hiding this comment.
For this class it would be possibly okay to hold a Logger instance. But, I also think this work is important and it's not necessary to be perfect from day one. Actually I'd appreciate if we could get this into Scene Builder 19. It will possibly turn out helpful as we would eventually get some useful logfiles in future.
Also, we could discuss how logging should be handled in future. I offer to run the necessary refactorings to implement the rules which we possibly might agree upon. But as of now, this PR will already be quite useful if merged.
Issue
Fixes #526
Progress