Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Remove outdated comments, clean up code #613

Merged
merged 2 commits into from
Mar 24, 2023
Merged

refactor: Remove outdated comments, clean up code #613

merged 2 commits into from
Mar 24, 2023

Conversation

AlmasB
Copy link
Collaborator

@AlmasB AlmasB commented Feb 7, 2023

Code maintenance

Issue

Relates to #445

Progress

@AlmasB AlmasB requested a review from jperedadnr February 7, 2023 21:43
Oliver-Loeffler
Oliver-Loeffler approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable for me. No need here to break this into 2 methods. The proposed way seems fine.

@abhinayagarwal abhinayagarwal merged commit 449d8e3 into gluonhq:master Mar 24, 2023
@AlmasB AlmasB deleted the almasb-cleanup branch May 11, 2023 21:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Oliver-Loeffler Oliver-Loeffler Oliver-Loeffler approved these changes

@jperedadnr jperedadnr jperedadnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlmasB @jperedadnr @Oliver-Loeffler @abhinayagarwal