Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: Use GITHUB_TOKEN for jreleaser #624

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

abhinayagarwal
Copy link
Collaborator

Update workflows to use GITHUB_TOKEN instead of PAT. kcctl/kcctl uses the same for JRELEASER_GITHUB_TOKEN.

Issue

Fixes #623

Progress

@abhinayagarwal abhinayagarwal changed the title Use GITHUB_TOKEN for jreleaser build: Use GITHUB_TOKEN for jreleaser Mar 27, 2023
@aalmiray
Copy link
Collaborator

A PAT will be needed if package managers such as brew and chocolatey become active. Currently they are configured but deactivated.

@abhinayagarwal
Copy link
Collaborator Author

@aalmiray Thanks for the heads up!

@erwin1 Should we proceed with GITHUB_TOKEN for now and revisit the PAT requirement when we decide to activate brew and chocolatey?

@erwin1
Copy link
Member

erwin1 commented Mar 28, 2023

@erwin1 Should we proceed with GITHUB_TOKEN for now and revisit the PAT requirement when we decide to activate brew and chocolatey?

yes, please proceed with the github token until we really need a pat

@abhinayagarwal abhinayagarwal merged commit c51d149 into gluonhq:master Mar 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jreleaser failing to push because of expired PAT
3 participants